Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35539: [C++] Remove use of internal header files from public header file #35592

Merged
merged 2 commits into from
May 16, 2023
Merged

GH-35539: [C++] Remove use of internal header files from public header file #35592

merged 2 commits into from
May 16, 2023

Conversation

ildipo
Copy link
Contributor

@ildipo ildipo commented May 15, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

Remove use of compute/util_internal.h in compute/key_map.h

@ildipo ildipo requested a review from westonpace as a code owner May 15, 2023 15:50
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35539 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

⚠️ GitHub issue #35539 has no components, please add labels for components.

@pitrou
Copy link
Member

pitrou commented May 16, 2023

Thanks @ildipo . I also removed use of arrow/util/logging.h which should be avoided in public headers.

@pitrou pitrou changed the title GH-35539: [C++] remove use of _internal.h header file from public header file GH-35539: [C++] Remove use of internal header files from public header file May 16, 2023
@github-actions
Copy link

⚠️ GitHub issue #35539 has no components, please add labels for components.

@pitrou pitrou merged commit 505a2e4 into apache:main May 16, 2023
@ursabot
Copy link

ursabot commented May 19, 2023

Benchmark runs are scheduled for baseline = af38263 and contender = 505a2e4. 505a2e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.1% ⬆️0.12%] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.45% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 505a2e45 ec2-t3-xlarge-us-east-2
[Finished] 505a2e45 test-mac-arm
[Finished] 505a2e45 ursa-i9-9960x
[Finished] 505a2e45 ursa-thinkcentre-m75q
[Finished] af382630 ec2-t3-xlarge-us-east-2
[Finished] af382630 test-mac-arm
[Finished] af382630 ursa-i9-9960x
[Finished] af382630 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 19, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace Awaiting requested review from westonpace

Assignees
No one assigned
Labels
awaiting review Awaiting review Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] Arrow 12.0.0-1 cpp exposes internal headers
3 participants
@ildipo @pitrou @ursabot